Pagination Pull Request

Task

A teammate used an AI assistant to add cursor pagination to the orders list of a support tool, and asked you to review the pull request. The code is short and its own tests pass. Read it against the endpoint contract, write your review comments in order of severity, and fix the problems that should block the merge.

Requirements

1. The checks call fetchPages(orders, query, options), a small client that is supplied. It requests a page, follows nextCursor for up to options.maxPages pages, and returns {status, pages, hasMore}: the order ids of every page and the hasMore flag of every page. It calls listOrders(orders, query), which you are reviewing. Do not change the arguments.
2. listOrders returns {status: 200, body: {items, nextCursor, hasMore}}. Items are whole orders, newest first. Orders created in the same instant are ordered by id, largest first. query.status, when present, keeps only orders with that status.
3. Query values are strings. limit is the page size: a missing limit, or one that is not a number, means 20. Any other value is clamped to the range 1 to 100.
4. hasMore is true only when at least one more order follows this page, and nextCursor is null when hasMore is false. A cursor is opaque to the client.
5. A client that follows nextCursor to the end sees every matching order exactly once. Orders that are added or deleted while it pages do not make another order repeat or go missing.
6. Write your review comments in REVIEW.md, most severe first, and fix the blocking ones in orders/list.js.